[Academy 전반] 스케줄 중복 여부 확인 로직 수정 및 학원 데이터 무한스크롤 방식으로 수정 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonu606
previously approved these changes
Dec 1, 2023
Comment on lines
+17
to
+18
| public static void checkOverlap(List<AcademySchedule> existedDateOverlappingSchedules, | ||
| List<GeneratedLessonSchedule> generatedSchedules) throws DateOverlapException { |
There was a problem hiding this comment.
변수명 단번에 이해했어요! 너무 잘 지은 것 같습니다👍
| } | ||
| } | ||
|
|
||
| private static boolean checkOverlap(AcademySchedule existedSchedule, GeneratedLessonSchedule generatedSchedule) { |
| @Query("select ash from AcademySchedule as ash " + | ||
| "join fetch ash.academyTimeTemplate as att " + | ||
| "where att.childId =:childId " + | ||
| "and ash.scheduleDate between :startDateOfAttendance and :endDateOfAttendance ") |
byeolhaha
changed the title
wonu606
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현
기존에 시간만 비교했던 잘못된 로직에서
날짜와 시간 모두 비교하여 중복된 일정이 없는지 체크하는 로직으로 변경하였습니다.
또한 중복된 일정을 만드는 경우 예외를 던지며 함께 중복된 대시보드의 아이디를 메세지로 전달합니다.
학원 필터 조회 및 중심 위치에 조회의 방식을 무한스크롤 방식으로 수정하였습니다.