Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Academy schedules] LikeAccessService를 Facade 패턴으로 변경 및 N+1 문제 개선 #126

Merged
merged 10 commits into from
Dec 9, 2023
Merged

[Academy schedules] LikeAccessService를 Facade 패턴으로 변경 및 N+1 문제 개선 #126

merged 10 commits into from
Dec 9, 2023

Conversation

byeolhaha
Copy link
Member

구현

  • LikeAccessService를 Facade 패턴으로 변경하여 AacademyService가 Academy 도메인만을 알도록 변경하였습니다.
  • Facade 패턴 도입에 따른 테스트 코드를 작성하였습니다.
  • 학원 목록 조회에서 카테고리 매핑할 때 N+1 문제가 발생하여 응답 시간이 1s~2s로 나와 이를 개선하였습니다.

@byeolhaha byeolhaha self-assigned this Dec 9, 2023
@byeolhaha byeolhaha added the enhancement New feature or request label Dec 9, 2023
@byeolhaha byeolhaha merged commit 350af5d into develop Dec 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onetuks onetuks Awaiting requested review from onetuks

@wonu606 wonu606 Awaiting requested review from wonu606

Assignees

@byeolhaha byeolhaha

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@byeolhaha