Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tableHeight conversion expression and type #250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yshkaym
Copy link

@yshkaym yshkaym commented Mar 11, 2023

Type

What types of changes does your code introduce?

Allow setting of strings so that "calc()" or similar can be used to make the table height follow the window height.
Example: table-height="calc(100vh - 150px)"

Put an x in the boxes that apply_

  • Fix
  • Feature

Checklist

Put an x in the boxes that apply._

  • Title as described
  • Add unit test by vitest if necessary

Copy link

@4levels 4levels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I'm not an expert nor a test maniac, but looks good enough to go even without explicit test. Great to see that this will allow CSS string statements to be passed as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants