Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update INSTALL files #4052

Merged
merged 12 commits into from
Mar 5, 2024
Merged

Update INSTALL files #4052

merged 12 commits into from
Mar 5, 2024

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Feb 27, 2024

No description provided.

@byrnHDF byrnHDF added Merge - To 1.14 Priority - 1. High 🔼 These are important issues that should be resolved in the next release Component - Documentation Doxygen, markdown, etc. Type - Improvement Improvements that don't add a new feature or functionality labels Feb 27, 2024
@byrnHDF byrnHDF self-assigned this Feb 27, 2024
jhendersonHDF
jhendersonHDF reviewed Feb 27, 2024
View reviewed changes
release_docs/USING_HDF5_VS.txt Outdated

https://portal.hdfgroup.org/display/knowledge/HDF+Knowledge+Base
https://forum.hdfgroup.org/c/hdf4/21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be https://forum.hdfgroup.org/c/hdf5/8?

hyoklee
hyoklee reviewed Feb 28, 2024
View reviewed changes
release_docs/INSTALL_CMake.txt Outdated
Configuration files:
HDF5config.cmake
HDF5options.cmake
"Use LIBAEC from original location" "https://gitlab.dkrz.de/k202009/libaec/-/archive/v1.0.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link requires login and 2 years old already. Is there an alternative? (E.g., https://github.com/erget/libaec/archive/refs/tags/v0.3.4.tar.gz)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be changed to match the same URLs used in hdf4.

hyoklee
hyoklee reviewed Feb 29, 2024
View reviewed changes
release_docs/INSTALL_CMake.txt Outdated
@@ -73,8 +73,8 @@ External compression szip and zlib libraries:
"Use ZLIB from original location" "https://github.com/madler/zlib/releases/download/v1.2.13"
"Use ZLIB from original compressed file" "zlib-1.3.tar.gz"

"Use LIBAEC from original location" "https://gitlab.dkrz.de/k202009/libaec/-/archive/v1.0.6"
"Use LIBAEC from original compressed file" "libaec-v1.0.6.tar.gz"
"Use LIBAEC from original location" "https://github.com/MathisRosenhauer/libaec/releases/download/v1.0.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get "Page not found" error.

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Feb 29, 2024 via email

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Feb 29, 2024 via email

hyoklee
hyoklee reviewed Mar 1, 2024
View reviewed changes
config/cmake/README.md.cmake.in Outdated
@@ -2,31 +2,26 @@
------------------------------------------------------------------------------

This directory contains the binary (release) distribution of
@HDF5_PACKAGE_NAME@ @HDF5_PACKAGE_VERSION_MAJOR@ that was compiled on;
@HDF5_PACKAGE_NAME@ @HDF5_PACKAGE_VERSION_MAJOR@.@HDF4_PACKAGE_VERSION_MINOR@ that was compiled on;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HDF4 -> 5?

hyoklee
hyoklee reviewed Mar 1, 2024
View reviewed changes
release_docs/USING_HDF5_CMake.txt Outdated
NOTE: this file is available at the HDF web site:
https://portal.hdfgroup.org/display/support/Building+HDF5+with+CMake
NOTE: this file is available in the HDF5 repository, for more information see:
https://github.com/HDFGroup/hdf5/blob/master/release_notes/USING_CMake_Examples.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404 File not Found

@derobins derobins merged commit 129d80d into HDFGroup:develop Mar 5, 2024
48 checks passed
lrknox pushed a commit to lrknox/hdf5 that referenced this pull request Mar 12, 2024
@byrnHDF @lrknox
Update INSTALL files (HDFGroup#4052)
63f5928
derobins added a commit that referenced this pull request Mar 13, 2024
@lrknox @byrnHDF
@jhendersonHDF @derobins
Sync develop branch changes March 4 - 6 to hdf5_1_14 branch (#4121)
5b7be28 
* Do not enable szip for sanitizer runs (#4057)

* Add note to H5Tset_fields about needing to set datatype precision first (#4059)

* Offset of a floating-point type also needs to be accounted for

* Clarify ordering of H5Tset_precision and H5Tset_fields

* Fix issue where H5Tset_fields does not account for datatype offsets (#4061)

H5Tset_fields did not account for any offset in a floating-point datatype,
causing it to fail when a datatype's precision is correctly set such that
it doesn't include the offset bits.

* Ignore UserPresets and Use only C compiler for sanitizers (#4066)

* Remove user presets file

* Only use C compiler for sanitzers

* Rename incorrectly named option (#4067)

* Rename incorrectly named option

* Restore the correct uses of USING_MEMCHECKER

* Update release note

* Fix a memory leak in the cmpd_dset test (#4071)

This was due to not freeing a test buffer. It was not a core
library memory leak.

* Fix uninitialized bytes in cmpd_dset test (#4072)

Compound fill values were set to the integer -1, causing valgrind
to flag 'uninitialized bytes' errors.

This is just a problem with the cmpd_dset test and not a core
library problem.

* Update INSTALL files (#4052)

* Add NEWSLETTER and merge abi reports and add sha256sums (#4055)

* Fix uninitialized bytes in selection I/O test (#4073)

This was due to a complex type fill value being set to -1 instead
of a proper complex value. This was a test problem and not a core
library issue.

* fix path for S3 build path in CI (#4076)

* Correct paths for 1.14 and add lines missing from release_docs/INSTALL_CMake.txt.

---------

Co-authored-by: Allen Byrne <[email protected]>
Co-authored-by: jhendersonHDF <[email protected]>
Co-authored-by: Dana Robinson <[email protected]>
@byrnHDF byrnHDF deleted the develop-release_files branch March 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendersonHDF jhendersonHDF jhendersonHDF left review comments

@derobins derobins derobins approved these changes

@hyoklee hyoklee hyoklee approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Documentation Doxygen, markdown, etc. Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
Downstream HDF5 Merges
Status: Needs Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@byrnHDF @derobins @hyoklee @jhendersonHDF