Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use matvis insteaf of vis_cpu #286

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Conversation

steven-murray
Copy link
Contributor

Refactors hera_sim to use the matvis name instead of vis_cpu.

Copy link
Contributor

@piyanatk piyanatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steven. This looks good. Just need some tidy up by replaceing occurrences of vis_cpu with matvis in the comments/docstrings, I think.

hera_sim/tests/test_compare_pyuvsim.py Outdated Show resolved Hide resolved
hera_sim/tests/test_compare_pyuvsim.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (9b0f8b8) 92.89% compared to head (9c66df9) 92.89%.
Report is 1 commits behind head on main.

Files Patch % Lines
hera_sim/visibilities/matvis.py 84.78% 18 Missing and 10 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files          24       24           
  Lines        3222     3222           
  Branches      705      705           
=======================================
  Hits         2993     2993           
  Misses        126      126           
  Partials      103      103           
Flag Coverage Δ
unittests 92.86% <84.86%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steven-murray steven-murray merged commit 45fc8cc into main Dec 11, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants