-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for transaction note #10
Conversation
I initially thought of adding a transaction note, but it wasn’t implemented at the time. Thank you for your contribution. For this specific pull request, our focus will be exclusively on Purpose No. 2, namely the addition of the Transaction Note feature. After successfully merging this, we'll move forward with a new pull request for Purpose No. 1. To advance with these changes, please follow these steps:
Thank you. |
@HPWebdeveloper It's all done now. |
I think I forgot to reimplement the feature after the rebase. Let me do that. |
Turned out I failed to add the reference field to the fillable property, I've done that now. |
suppose user published the config file and doesn't provide a correct value for the 'log_reference_generator' => null, what he provides is wrong and it is not invokable. In this case there is a need to have Exceptions here: https://github.com/HPWebdeveloper/laravel-pay-pocket/blob/main/src/Traits/BalanceOperation.php Can you complete it? |
Currently it falls back to Str:random() |
There are times when you want to ensure that only specific wallets are charged during a transaction, this PR adds support for optionally specifying which wallets should be charged in such scenarios, instead of attempting to charge all wallets.
A possible use case for this is in an escrow system where funds needs to stay locked in untill an approval is given.
This PR also adds support for including short transactional notes, possibly to provide context to the user.
Both features are covered by all possible test cases.
See Issue #8