Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revenues summed too many times #577

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

samulikyytsonen
Copy link
Collaborator

This affects only to the results in .txt file - not CBA-excel

zptro
zptro previously approved these changes Oct 23, 2024
Copy link
Collaborator

@zptro zptro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@hsl-petrhaj
Copy link
Contributor

hsl-petrhaj commented Oct 23, 2024

@samulikyytsonen I am not so familiar with this part, but why is the proposed behavior inconsistent with how cars are counted? Is there some underlying difference?
Edit: It seems to me that the car part is then wrong as well.

Copy link
Contributor

@hsl-petrhaj hsl-petrhaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks consistent, thank you for the PR. You can squash merge that into olusanya now (as usual).

@samulikyytsonen
Copy link
Collaborator Author

Seems that I don't have rights to do the merge. I need to be authorized for that

@hsl-petrhaj hsl-petrhaj merged commit 75a2a79 into olusanya Oct 23, 2024
2 checks passed
@hsl-petrhaj hsl-petrhaj deleted the fix/cba-transit-revenue branch October 23, 2024 07:41
@hsl-petrhaj
Copy link
Contributor

Thanks for letting me know, it is merged now. I will check the policies later in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants