error estimation test #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenhorn
reviewed
Nov 24, 2023
test/unit/ErrorEstimationTest.cpp
Outdated
|
|
||
| coupling::error::ErrorEstimation errorControl(velocity, temperature, numberOfParticle, particleMass, soundSpeed, numberOfSamples, cellVolume); | ||
| double errorVelo = errorControl.getError(coupling::error::ErrorEstimation::Velocity, coupling::error::ErrorEstimation::Absolute); | ||
| CPPUNIT_ASSERT(errorVelo == 0.25); |
There was a problem hiding this comment.
Is it safe here to compare doubles using == instead of abs(a-b)<epsilon? (see also _testDensityError(...))
test/unit/ErrorEstimationTest.cpp
Outdated
|
|
||
| coupling::error::ErrorEstimation errorControl(velocity, temperature, numberOfParticle, particleMass, soundSpeed, numberOfSamples, cellVolume); | ||
| double errorVelo = errorControl.getError(coupling::error::ErrorEstimation::Velocity, coupling::error::ErrorEstimation::Absolute); | ||
| CPPUNIT_ASSERT(errorVelo == 0.25); |
There was a problem hiding this comment.
Why are the expected values hardcoded here instead of also being passed into the function as a parameter? They seem to depend on the concrete values, right? (also see _testDensityError(...))
Thinkpiet
requested changes
Nov 24, 2023
…o into error_estimation_unit_test
…stimationTest.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.