Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed thermostat applied on wrong number of cell layers #83

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

Thinkpiet
Copy link
Member

fixes #78

@Thinkpiet
Copy link
Member Author

Background:
In old MaMiCo versions, datastructures::MacroscopicCells::applyXLayersOfGlobalNonGhostCellsWithLinkedCells() used to call apply() on X+1 layers. Thus, the thermostat configuration for type=outerLayers used to pass X-1 layers, to compensate.
When refactoring to new index system, we fixed this, so that
datastructures::LinkedCellContainer::applyXLayersOfGlobalNonGhostCellsWithLinkedCells() now actually uses X layers. However, since thermostat configuration was still doing the X-1, number-layers="1" caused the thermostat to be turned off completely. This causes the fluid to cool down, spontaneously decompose, regions without particles yield the zero values in the filter which were mentioned in #78

@Thinkpiet Thinkpiet merged commit 8e00ead into master Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Output generates rows of zeros
2 participants