Skip to content

Commit

Permalink
Exclude non-ascii files from windows native snippet tests (apple#739)
Browse files Browse the repository at this point in the history
There is an existing bug that is preventing the CLI from loading
these files.
  • Loading branch information
bioball authored Oct 26, 2024
1 parent 08be6be commit 466ae6f
Showing 1 changed file with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -309,12 +309,20 @@ private val windowsExcludedTests
// error message contains different file path on Windows
Regex(".*missingProjectDeps/bug\\.pkl"),
// URIs get rendered slightly differently (percent-encoded vs raw)
Regex(".*日本語_error\\.pkl")
Regex(".*日本語_error\\.pkl"),
)

private val windowsNativeExcludedTests
get() =
listOf(
// CLI args on Windows turn into `?` when in native image
// https://github.com/oracle/graal/issues/8593
Regex(".*日本語\\.pkl")
)

class WindowsLanguageSnippetTestsEngine : AbstractNativeLanguageSnippetTestsEngine() {
override val pklExecutablePath: Path = PklExecutablePaths.windowsAmd64
override val testClass: KClass<*> = WindowsLanguageSnippetTests::class
override val excludedTests: List<Regex>
get() = super.excludedTests + windowsExcludedTests
get() = super.excludedTests + windowsNativeExcludedTests + windowsExcludedTests
}

0 comments on commit 466ae6f

Please sign in to comment.