Add set window focus support to hldx/hlsdl #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds winRaise to hlSdl and winSetFocus to hldx. These are plumbed through to their respective window classes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds winRaise to hlSdl and winSetFocus to hldx. These are plumbed through to their respective window classes as well.
Both methods tested and working on windows 10
For winSetFocus (directx), minver is Windows 2000, not deprecated, should be safe.
for winRaise (sdl), min SDL version is 2.0.0, we should trust SDL to handle the rest.
Naming was chosen to match the underlying functions and following existing naming conventions, but I can rename either one for consistency if that is preferred.
This has a variety of minor uses in games, but the main driver is for imgui multi-window work, where we want a specific tool to grab focus for workflow reasons.