Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Enable hlc tests on windows and mac #11768

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

tobil4sk
Copy link
Member

Enables hlc tests on windows with gcc and mac with clang.

It would still be a good idea to compile on windows with msvc, but the unit tests aren't passing yet, that is being handled in: #11733.

This allows for a proper install with all the paths set up correctly
Using gcc on windows and clang on mac
@skial skial mentioned this pull request Sep 17, 2024
1 task
@Simn
Copy link
Member

Simn commented Oct 15, 2024

@yuxiaomao Could you check/merge this?

@yuxiaomao
Copy link
Contributor

Seems good for me. However, @tobil4sk also showed me when optimization flags (-O3) are enabled - some tests are failing similar to the msvc case, we might needs to address that too

@yuxiaomao yuxiaomao closed this Oct 15, 2024
@yuxiaomao yuxiaomao reopened this Oct 15, 2024
@yuxiaomao yuxiaomao merged commit 5c19536 into HaxeFoundation:development Oct 15, 2024
58 of 59 checks passed
@tobil4sk tobil4sk deleted the hlc-tests-windows-mac branch October 15, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants