UI: book: add fairy buttons #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helco
requested changes
Jan 25, 2024
zzre/game/systems/ui/ScrBookMenu.cs
Outdated
Comment on lines
54
to
57
| foreach (var ownedFairy in inventory.Fairies) | ||
| { | ||
| if (ownedFairy.cardId == fairyRow.CardId) | ||
| { |
There was a problem hiding this comment.
Instead of looping through yourself you can use inventory.Contains(fairies[i].CardId)
There was a problem hiding this comment.
thank you, fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds correctly positioned fairy buttons to the fairy book menu.
Buttons are not clickable, extra indicators (yellow triangle, green box) are not implemented.
The loop is O(n^2) unfortunately, it can be rewritten to be O(n) with hashmaps, but that's beyond my skill level with C# (which i've never used before lol).