Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework asynchronous asset registry #391

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Rework asynchronous asset registry #391

wants to merge 29 commits into from

Commits on Oct 22, 2024

  1. Fix pedantic IDE warnings in asset registry

    @Helco
    Helco committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f1572e7 View commit details
    Browse the repository at this point in the history

  2. Add first two test cases

    @Helco
    Helco committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    5920c65 View commit details
    Browse the repository at this point in the history

  3. Fix AssetHandle equality and add more test cases

    @Helco
    Helco committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    a576120 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Add even more test cases

    @Helco
    Helco committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    873ff60 View commit details
    Browse the repository at this point in the history

  2. You guessed it. 

    More test cases (with two currently failing)
    @Helco
    Helco committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    07db850 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Fix WaitAsyncAll not checking disposed handles

    @Helco
    Helco committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c0223d8 View commit details
    Browse the repository at this point in the history

  2. Add TestCases for applying async assets

    @Helco
    Helco committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4429778 View commit details
    Browse the repository at this point in the history

  3. Add first batch of secondary asset tests

    @Helco
    Helco committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    04dec31 View commit details
    Browse the repository at this point in the history

  4. Couple more test cases

    @Helco
    Helco committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9734c81 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. More secondary asset tests

    @Helco
    Helco committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ec63f59 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Fix apply action not called when Load while loaded asynchronously

    @Helco
    Helco committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8fe1d3a View commit details
    Browse the repository at this point in the history

  2. Improve tests for async apply

    @Helco
    Helco committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    48ab189 View commit details
    Browse the repository at this point in the history

  3. Use TryWrite instead of WriteAsync and lock assets on registry disposal

    @Helco
    Helco committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    67a4f8c View commit details
    Browse the repository at this point in the history

  4. Replace synchronous wait on task with direct exception dispatch

    @Helco
    Helco committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    572db4f View commit details
    Browse the repository at this point in the history

  5. Use Assert.Inconclusive instead of Ignore

    @Helco
    Helco committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2197015 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Add low-then-high/sync tests

    @Helco
    Helco committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    fb61d3f View commit details
    Browse the repository at this point in the history

  2. Fix asset disposal on primary error

    @Helco
    Helco committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3a02dbe View commit details
    Browse the repository at this point in the history

  3. Add secondary error tests and fix exceptions being swallowed by Task.… 

    …WhenAll
    @Helco
    Helco committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    8c48d30 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Now I am become deadlock, the breaker of tests

    @Helco
    Helco committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    1983f67 View commit details
    Browse the repository at this point in the history

  2. Asset.Load is now synchronous. 

    This breaks everything eeeveen further
    @Helco
    Helco committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    4f7b12c View commit details
    Browse the repository at this point in the history

  3. Unfortunately fix all tests by adding async asset loading

    @Helco
    Helco committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    333f5d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Let the deadlocks surface in the tests instead of crashing the test p… 

    …rocess with a somewhat unrelated exception
    @Helco
    Helco committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bdbe383 View commit details
    Browse the repository at this point in the history

  2. ci: Add timeout to test steps

    @Helco
    Helco committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    9fa8fc0 View commit details
    Browse the repository at this point in the history

  3. CI should have failed...

    @Helco
    Helco committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d6a607b View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Lost confidence in this approach. Let's try that again

    @Helco
    Helco committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    990053f View commit details
    Browse the repository at this point in the history

  2. Revert "Lost confidence in this approach. Let's try that again" 

    This reverts commit 990053f.
    @Helco
    Helco committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ea240f8 View commit details
    Browse the repository at this point in the history

  3. Broke everything in another way with slightly simpler asset locking

    @Helco
    Helco committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0eb5588 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Remove STA apartment

    @Helco
    Helco committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6c50189 View commit details
    Browse the repository at this point in the history

  2. Fix some problems 

    - Not queuing low assets
- Not dereferencing assets
- Not queuing apply actions
- Readd STA and postpone fixing Linux CI
    @Helco
    Helco committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    832cb66 View commit details
    Browse the repository at this point in the history