-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get default long press delay value from Android settings #559
base: main
Are you sure you want to change the base?
Conversation
Here are the values in Android's settings for long press delay: |
The default long press delay value is set within Android's Settings --> Accessibility --> Touch & hold delay, so use that as the default value in Heliboard as well. Also, increase the max long press delay value to 1500 so that it matches the max value in Android's settings.
f4f2b84
to
63bd137
Compare
Updated variable name |
I see the reasoning, but at the same time it looks like there was no request for increasing the maximum to more than 700 ms. |
If Android's default settings are not changed, the default value is 500ms on <= Nougat and 400ms >= Oreo. The only reason I increased the max value to 1500ms is so that it would be able to match the maximum value in Android's settings. Most people would probably not change these default settings. The idea is to just be able to provide consistency between the keyboard and Android's system values. |
I had a while to think about this, and decided I do not want to change the default value. This PR will increase the value for every user who is using the default value by at least 100 ms, which is quite noticeable, and I expect to be unwanted by most users. |
I understand your decision. I would also like to mention though that when the long press timeout of an application does not match the long press timeout of android's system settings, the following error can occur when quickly touching the UI: On Android 7 the relative code is in Session.java and is later moved into WindowManagerService.java on newer versions of Android. Edit: Although, this seems to only be affected when "dragging" objects |
This is inside |
yes, I guess the keyboard would not be affected by this since I dont see any "dragging" being used. |
Maybe this could be revisited if this keyboard adds some kind of "floating" functionality. |
I agree, the floating window would definitely use drag functionality, and also a longer delay would make sense there. |
The default long press delay value is set within Android's Settings --> Accessibility --> Touch & hold delay, so use that as the default value in Heliboard as well. Also, increase the max long press delay value to 1500 so that it matches the max value in Android's settings.