Get default long press delay value from Android settings

[syphyr]

The default long press delay value is set within Android's Settings --> Accessibility --> Touch & hold delay, so use that as the default value in Heliboard as well. Also, increase the max long press delay value to 1500 so that it matches the max value in Android's settings.

[syphyr]

Here are the values in Android's settings for long press delay:
https://android.googlesource.com/platform/packages/apps/Settings.git/+/master/res/values/arrays.xml#643

[syphyr]

Updated variable name

[Helium314]

increase the max long press delay value to 1500 so that it matches the max value in Android's settings

I see the reasoning, but at the same time it looks like there was no request for increasing the maximum to more than 700 ms.
Seeing these quite large values makes me wonder whether it really is a good idea to have such defaults. Do you know which value is the default setting for the Android system?

[syphyr]

If Android's default settings are not changed, the default value is 500ms on <= Nougat and 400ms >= Oreo. The only reason I increased the max value to 1500ms is so that it would be able to match the maximum value in Android's settings. Most people would probably not change these default settings. The idea is to just be able to provide consistency between the keyboard and Android's system values.

[Helium314]

I had a while to think about this, and decided I do not want to change the default value. This PR will increase the value for every user who is using the default value by at least 100 ms, which is quite noticeable, and I expect to be unwanted by most users.

[syphyr]

I had a while to think about this, and decided I do not want to change the default value. This PR will increase the value for every user who is using the default value by at least 100 ms, which is quite noticeable, and I expect to be unwanted by most users.

I understand your decision. I would also like to mention though that when the long press timeout of an application does not match the long press timeout of android's system settings, the following error can occur when quickly touching the UI:

https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-7.1.2_r39/services/core/java/com/android/server/wm/Session.java#339

On Android 7 the relative code is in Session.java and is later moved into WindowManagerService.java on newer versions of Android.

Edit: Although, this seems to only be affected when "dragging" objects

[Helium314]

https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-7.1.2_r39/services/core/java/com/android/server/wm/Session.java#339

This is inside performDrag, which I would (perhaps naively?) assume to be unused in the keyboard

[syphyr]

https://android.googlesource.com/platform/frameworks/base/+/refs/tags/android-7.1.2_r39/services/core/java/com/android/server/wm/Session.java#339

This is inside performDrag, which I would (perhaps naively?) assume to be unused in the keyboard

yes, I guess the keyboard would not be affected by this since I dont see any "dragging" being used.

[syphyr]

Maybe this could be revisited if this keyboard adds some kind of "floating" functionality.

[Helium314]

I agree, the floating window would definitely use drag functionality, and also a longer delay would make sense there.