Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nexo support #161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

simondumalski
Copy link

@simondumalski simondumalski commented Dec 8, 2024

I have created this pull request that adds Nexo support to DeluxeMenus (#155). I have tested this on my development server and have not encountered any issues. The implementation is nearly identical to the existing Oraxen hook.
Some things to note:

  • The Nexo API requires Java 21, so I have had to update the target and source compatibility to that.
  • The existing shadow plugin is not compatible with Java 21, so I have updated it to the shadow plugin that is being maintained by Gradle.

Copy link
Member

@iGabyTM iGabyTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't just bump the java version by 10 releases to add support for a plugin. This needs to be announced first.

@simondumalski
Copy link
Author

We can't just bump the java version by 10 releases to add support for a plugin. This needs to be announced first.

Yes, this PR is more to let HelpChat know that if they want to support Nexo, they'll have to update to Java 21, as well as add the hook itself so that if anyone wants to compile it themselves, they can. Other plugins that have added Nexo support have marked their Oraxen support as Deprecated, such as CrazyCrates and HMCCosmetics.

@FaultyFunctions
Copy link

Any news on this?

@simondumalski
Copy link
Author

I've been told a version of the Nexo API that doesn't require Java 21 is potentially being worked on. Will update this if that ever comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants