fix error when one URL is called twice consecutively #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it an unreachable logical path? |
JesseRiemens
suggested changes
Nov 20, 2021
| @@ -78,6 +78,7 @@ bool handleAcs(HTTPMethod method, String uri) { | |||
| else { | |||
| return false; // Not found to accessing exception URI. | |||
| } | |||
| currentUri = String(""); | |||
There was a problem hiding this comment.
This statement will never be reached since it is below an if else with a return in it. Besides, it defies the check. Why would this statement be beneficial?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the exampe
DynamicPage.ino, in the methodhandleAcs,currentUriis set to the parameterurito check if the method is called the first or second time during a request. However, when one URL is requested twice consecutively,currentUriis still set to that URL from the previous request. This PR fixes it by resettingcurrentUrito an empty string after every successfull URL handling.