Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds syntax to update records without completely de-constructing and re-constructing them.
The added syntax is for example:
I don't think @VictorTaelin will like the syntax like this, so I would like to hear some suggestions on how it should be.
The code in this PR already translates it into JS using object update syntax, which shouldn't be worse performance-wise than the previous method of creating a new record from scratch.
The reduction code for this term is not the best it could be. If there were an additional compilation stage to change terms after checking but before reducing, we could force every constructor to have all of its fields named and sorted (maybe inserted into a map), so the actual updating would be trivial and performant.