Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record update syntax #613

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Add record update syntax #613

wants to merge 10 commits into from

Conversation

edusporto
Copy link
Contributor

This PR adds syntax to update records without completely de-constructing and re-constructing them.

The added syntax is for example:

change : (Pair String String) -> (Pair String String)
| p = record p { fst: (String/append "hel" "lo") }
//    --------------------------------------------

I don't think @VictorTaelin will like the syntax like this, so I would like to hear some suggestions on how it should be.

The code in this PR already translates it into JS using object update syntax, which shouldn't be worse performance-wise than the previous method of creating a new record from scratch.

The reduction code for this term is not the best it could be. If there were an additional compilation stage to change terms after checking but before reducing, we could force every constructor to have all of its fields named and sorted (maybe inserted into a map), so the actual updating would be trivial and performant.

@edusporto edusporto marked this pull request as draft November 8, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant