Add custom file storage setting: "FILE_STORAGE_BACKEND" #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicertel
reviewed
Feb 24, 2021
| @@ -19,7 +19,7 @@ class SentEmail(models.Model): | |||
| to_email = models.EmailField() | |||
| from_email = models.EmailField() | |||
| subject = models.TextField() | |||
| html = models.FileField(upload_to=sent_email_upload_path) | |||
| html = models.FileField(upload_to=sent_email_upload_path, storage=get_file_storage_backend) | |||
There was a problem hiding this comment.
Does the storage field accept callable? I though it's expecting instance of a storage or none.
There was a problem hiding this comment.
It accepts callable, I checked the source code and also tested in one of our projects.
It calls the callable and gets an instance of subclass of django.core.files.storage.Storage.
alicertel
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will update README after you approve changes.