More STYLE.md updates #2092
Merged
More STYLE.md updates #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes LGTM. Would you also be able to hard-wrap some of the paragraphs? I think we wrap at 80 (emacs default). We don't use proviola any longer and the extra bug minimizer section no longer looks relevant. |
|
Lines wrapped. Should we wait to hear what Jason says about the bug minimizer, or just go ahead and merge? |
JasonGross
reviewed
Sep 17, 2024
Co-authored-by: Jason Gross <[email protected]>
|
I'll go ahead and merge unless I hear any other suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typos I noticed today, plus a couple of obsolete things.
I pretty sure that the whole last part of the bug minimizer discussion is not needed anymore, since it was about using hoqc, which we no longer use. @JasonGross , let me know if I'm right about that. (The third commit below.)