Handle multiple lines correctly #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
approved these changes
Sep 23, 2022
| @@ -42,13 +42,14 @@ def parse_paragraph_in_edifact_struktur_column_to_dataframe( | |||
| elif tab_count == 1: | |||
| dataframe.at[row_index, "Segment Gruppe"] = splitted_text_at_tabs[0] | |||
| dataframe.at[row_index, "Segment"] = splitted_text_at_tabs[1] | |||
| elif tab_count == 0 and not paragraph.text == "": | |||
| if paragraph.runs[0].bold: | |||
| elif tab_count == 0 and joined_text != "": | |||
There was a problem hiding this comment.
müsste man joined_text hier für den empty-string vergleich nicht strippen? zwei leere paragraphen gejoined wären ja mindestens ein leerzeichen.
There was a problem hiding this comment.
good point. Habe s ergänzt in 28708aa
| @@ -325,10 +325,10 @@ def test_parse_paragraph_in_edifact_struktur_column_to_dataframe( | |||
|
|
|||
| # insert text | |||
| self.test_cell.text = text_content | |||
| test_paragraph = self.test_cell.paragraphs[0] | |||
| test_paragraph = [self.test_cell.paragraphs[0]] | |||
There was a problem hiding this comment.
ich weiß, ich hab das uach nicht gemacht, aber ein unittest für eine mehrzeilige überschrift wäre nice.
There was a problem hiding this comment.
bin generell mit dem test setup unzufrieden da es noch recht komplex ist.
Ich nehme mal den Punkt in ein Ticket auf, damit wir es nicht vergessen.
Würde das erstmal hinten anstellen wenn es okay ist.
hf-krechan
added a commit
that referenced
this pull request
Sep 26, 2022
* 📝🚧 Make a small mermaid diagram to get the idea of the workflow and add persona to concentrate on one goal first * 🙈 Add macOS related files to gitignore * 🚧🎨 Add Elixir class * 🚧 working WIP * 🔥 Delete deprecated lines * 🚧 change ahb_file_name * 🩹 Fix row_index counting * 🔥 replace row * 💡 Update docstrings * ✅ Update unit tests * ✅ Fix unit tests * 🚨 Fix linter warnings * 🔄 Update dependencies * 🎨 Apply isort * 🏷 Remove unnecessary type hint Co-authored-by: konstantin <[email protected]> * 🏷 Remove type hint Co-authored-by: konstantin <[email protected]> * Handle multiple lines correctly (#28) * Handle multiple lines correctly * 🩹 Fix issues after cherry pick * ✅🩹 Fix broken unitttests * ⚙️ Add setting for pytest to fix import issue * 🚨 Fix linter warnings * 🎨 Strip joined_text in elif conidtion * 🎨 Improve readability for columns creation * 🎨 improve variable name for name of base columnes * 🩹 Fix errors after merging * 🚨 Fix linter and ignore mypy warnings * 🩹 Fix issue that sometimes there are empty lines with only Bedingung * 💡 Write some explanation * 💡 Add reason for the classmethod in Elixir Co-authored-by: konstantin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.