feat(time conditions): add ub packages #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-krechan
approved these changes
Sep 11, 2024
hf-kklein
reviewed
Sep 11, 2024
| @@ -123,3 +123,14 @@ def dump_as_json(self, output_directory_path: Path) -> None: | |||
| edifact_format, | |||
| file_path, | |||
| ) | |||
|
|
|||
|
|
|||
| def extract_number(key: str) -> float: | |||
There was a problem hiding this comment.
warum float? das wird doch nie ne komma stelle haben?
There was a problem hiding this comment.
Bisschen shady, aber war ein workaround um die typehints einheitlich auf ein Type zu bekommen 😬
There was a problem hiding this comment.
it's not shady if it works.
aber kannst du einfach das "warum?" im code kommentieren?
hf-kklein
reviewed
Sep 11, 2024
unittests/test_ahbpackagetable.py
Outdated
| pytest.param("UB", float("inf"), id="UB"), | ||
| ], | ||
| ) | ||
| def test_extract_number(self, key: str, expected: Optional[int]): |
There was a problem hiding this comment.
aber hier müsste dann optional float sein?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.