os/mac/pkgconfig/15: add bzip2.pc for rust formulae #18545
Draft
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Mainly since the only way to avoid bundled
bzip2
in rust formulae is viapkg-config
- https://github.com/alexcrichton/bzip2-rs/blob/master/bzip2-sys/build.rs#L16-L23Similar to pkgconfig file created inside
bzip2
formula based on https://gitlab.com/bzip2/bzip2/-/blob/master/bzip2.pc.in (note that we currently only ship shared libraries & pkg-config file on Linux, so using brewbzip2
is particularly bad option on macOS).Removed
bindir=
and-I${includedir}
in Cflags.Only added macOS 15 for initial discussion. If acceptable, can add older macOS versions.