Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Balena Etcher builds for Apple Silicon #120552

Closed
wants to merge 3 commits into from
Closed

Add Balena Etcher builds for Apple Silicon #120552

wants to merge 3 commits into from

Conversation

nilsstreedain
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

@bevanjkay
Copy link
Member

bevanjkay commented Mar 16, 2022

@nilsstreedain Thank you for your submission but we should not be distributing a community build to users expecting to receive the application from the actual authors.

@bevanjkay bevanjkay closed this Mar 16, 2022
@nilsstreedain
Copy link
Contributor Author

nilsstreedain commented Mar 16, 2022

@nilsstreedain Thank you for your submission but we should not be distributing a community build to users expecting to receive the application from the actual authors.

This is built using the codebase of BalenaEtcher (just recompiled for Apple Silicon) which is written to support Apple Silicon and is specifically referenced by BalenaEtcher maintainers in balena-io/etcher#3595. They went this route because they do not currently have an Apple Silicon Mac in their build pipeline.

@bevanjkay
Copy link
Member

@nilsstreedain I do understand that, but homebrew-cask should not be distributing a community build in a cask where a user would be expecting to receive the vendor build.

See this note from upstream's issue: balena-io/etcher#3714

Note: These versions are not built, maintained, or supervised by balena, so proceed with caution.

@nilsstreedain
Copy link
Contributor Author

It has been pointed to by Balena maintainers as what to use while they determine how to move forward with their build structure but I understand. Would it be reasonable for me to create a separate balenaetcher-community cask in the meantime?

@nilsstreedain nilsstreedain deleted the patch-1 branch March 17, 2022 02:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants