Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trezor-agent: migrate to [email protected], drop keepkey-agent #193707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 11, 2024

  • Drop keepkey-agent packages as we have a separate formula
  • Unbundle hidapi and libsodium
  • Make sure to resolve all OS-specific Python packages
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

* Drop `keepkey-agent` packages as we have a separate formula
* Unbundle `hidapi` and `libsodium`
* Make sure to resolve all OS-specific Python packages
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 11, 2024
@cho-m cho-m removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 11, 2024
@cho-m cho-m marked this pull request as ready for review October 11, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant