-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major overhaul of documentation towards version 0.6 #96
base: master
Are you sure you want to change the base?
Conversation
Is it ok with you if I take some time this weekend to review it? |
@seb-mueller Found a couple of mistakes here and there. Can you create a feature branch called: feature/doc_v0.6 and PR on this. Maybe I can pull from it and then push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR was made superseded, as a reminder, could you still have a look at the comments below?
|
||
### 3. gtf_biotypes.yaml | ||
|
||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hoohm , could you maybe at a sentence here to explain? I couldn't find any info about his so far, but it seems important to explain.
|
||
* `expected_cells` is the number of cells you expect from your sample. | ||
* `read_length` is the read length of the mRNA (Read2). This is necessary for STAR index generation | ||
* `batch` Can be used to group samples into batches. If new samples are added to the same experiment, a new batch should be assigned to those samples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a good explanation? There is usually a lot of confusion for the batch, do you have anything to add for it's original purpose?
docs/docs/Running-dropSeqPipe.md
Outdated
|
||
*Note: You are likely to run into problems when using `--use-cond` when running your pipeline while being in active conda environment. | ||
You should deactivate beforehand if in doubt using `conda deactivate`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addresses issue #90
Just updated the documentation with major restructuring based on some user feedback who found it was a bit confusing to follow.
It's now more logically structured in, 1) installing, 2) setting up an exeriment, 3) running
The files are renamed/merged to reflect that, i hope you agree with it!?
Most notably, the new
Setting-up-an-experiment.md
combines the now deleted clusters.md, Create-config-files.md and Reference-Files.md.I thought to use a PR rather than push it directly to be able discuss the changes here.