implemented more error handling

implemented more error handling, especially for async methods
HotCakeX · Jul 27, 2024 · 1d1abdb · 1d1abdb
1 parent 3b4ed38
commit 1d1abdb
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/Harden-Windows-Security Module/Main files/C#/AsyncDownloader.cs b/Harden-Windows-Security Module/Main files/C#/AsyncDownloader.cs
@@ -168,7 +168,8 @@ public static void PrepDownloadedFiles(bool GUI = false, string LGPOPath = null,
 
                 if (DownloadsTask.IsFaulted)
                 {
-                    throw new Exception(DownloadsTask.Exception.Message);
+                    // throw the exceptions
+                    throw DownloadsTask.Exception;
                 }
                 else if (DownloadsTask.IsCompletedSuccessfully)
                 {

diff --git a/Harden-Windows-Security Module/Main files/C#/ConfirmSystemComplianceMethods.cs b/Harden-Windows-Security Module/Main files/C#/ConfirmSystemComplianceMethods.cs
@@ -48,11 +48,14 @@ public static void OrchestrateComplianceChecks(params string[] methodNames)
             if (MethodsTaskOutput.IsFaulted)
             {
                 // throw the exceptions
-                throw new Exception(MethodsTaskOutput.Exception.Message);
+                throw MethodsTaskOutput.Exception;
+
+                // this should automatically throw ?
+                // MethodsTaskOutput.GetAwaiter().GetResult()
             }
             else if (MethodsTaskOutput.IsCompletedSuccessfully)
             {
-                //   Console.WriteLine("Download completed successfully");
+                // Console.WriteLine("Download completed successfully");
             }
         }
 

diff --git a/Harden-Windows-Security Module/Main files/C#/WriteVerbose.cs b/Harden-Windows-Security Module/Main files/C#/WriteVerbose.cs
@@ -13,10 +13,17 @@ public static class VerboseLogger
         /// <param name="message"></param>
         public static void Write(string message)
         {
-            if (HardeningModule.GlobalVars.VerbosePreference == "Continue" || HardeningModule.GlobalVars.VerbosePreference == "Inquire")
+            try
             {
-                HardeningModule.GlobalVars.Host.UI.WriteVerboseLine(message);
+                if (HardeningModule.GlobalVars.VerbosePreference == "Continue" || HardeningModule.GlobalVars.VerbosePreference == "Inquire")
+                {
+                    HardeningModule.GlobalVars.Host.UI.WriteVerboseLine(message);
+                }
             }
+            // Do not do anything if errors occur
+            // Since many methods write to the console asynchronously this can throw errors
+            // implement better ways such as using log file or in the near future a GUI for writing verbose messages when -Verbose is used
+            catch { }
         }
     }
-}
+}