Check Store ID when Checking for Duplicate Variants #492
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple stores exist and you attempt to add a variant to a product it does not currently filter by StoreId and gives an error message abut the SKU already existing. Even though the SKU doesn't exist in the current store. This adds a stored check based on the current context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple stores exist, and you attempt to add a variant to a product, it is not currently filtered by StoreId. It gives an error message about the SKU already existing even though the SKU doesn't exist in the current store.
This adds a stored check based on the current context.
Related to Issue
No issue currently exists
Description
Gets the current store id from the context and filters what variants we are looking for by the store id.
Types of changes
Checklist: