Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good works is 1 by 9a. #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nikolaikolya
Copy link

Thank you very much for your work!

Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see solutions folder

@@ -1,5 +1,6 @@
'use strict';

const hello = null;
const hello = name => console.log(`Hello, ${name}!`);
hello('Kolyan');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't call it here, just export, we have tests to call

@@ -1,5 +1,6 @@
'use strict';

const hello = null;
const hello = name => console.log(`Hello, ${name}!`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const hello = name => console.log(`Hello, ${name}!`);
const hello = name => {
console.log(`Hello, ${name}!`);
};

@@ -1,5 +1,13 @@
'use strict';

const range = null;
const range = (start, end) => {
const arr = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may allocate array with known final length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants