Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phoenix Live Dashboard with Absinthe metrics #404

Closed
wants to merge 6 commits into from

Conversation

johnshaughnessy
Copy link
Contributor

@johnshaughnessy johnshaughnessy commented Aug 7, 2020

Experimental

image

  • Upgrade phoenix and other dependencies
  • Add phoenix_live_dashboard
  • Add request logger
  • Add absinthe telemetry events for monitoring graphql api performance

Issues:

  • This should be broken into two parts: Upgrade phoenix and other dependencies first, then add phoenix_live_dashboard and absinthe telemetry events.
  • Need to make sure elixir/erlang versions running in production are compatible with the upgraded dependencies.

{:gettext, "~> 0.17"},
{:cowboy, "~> 2.6.3"},
{:plug_cowboy, "~> 2.0"},
{:cowboy, "~> 2.8"},
Copy link
Contributor Author

@johnshaughnessy johnshaughnessy Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we upgrade cowboy to 2.8, then we need to make sure we are running erlang 22+

See phoenixframework/phoenix#3950

It looks like we are running 22.0 in habitat deploys:
https://github.com/mozilla/hubs-ops/blob/master/plans/erlang/habitat/plan.sh#L3

Need to confirm this and check terraform / hmc

@johnshaughnessy johnshaughnessy changed the title Feature/upgrade phx graphql telemetry Add Phoenix Live Dashboard with Absinthe metrics Aug 7, 2020
Base automatically changed from feature/graphql-2 to master December 14, 2020 20:00
@brianpeiris
Copy link
Contributor

Just noting this here for when we do end up upgrading phoenix. From a discussion in discord:

there is an ugly bug in the toml lib in elixir that causes the server to not start if you update elixir to the latest - fix is easy just bump the toml lib

This was referenced Jan 21, 2021
@johnshaughnessy
Copy link
Contributor Author

Closing this in favor of #461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants