Allow for PNG brand logos in experience block

[rodrigoalcarazdelaosa]

Purpose

Fixes #2952.

Documentation

This documentation should be updated to reflect the change.

[netlify]

✅ Deploy Preview for markdown-slides canceled.

Name	Link
🔨 Latest commit	3a9d21d
🔍 Latest deploy log	https://app.netlify.com/sites/markdown-slides/deploys/65266071069f0d000838bdd0

[netlify]

✅ Deploy Preview for hugo-portfolio-theme canceled.

Name	Link
🔨 Latest commit	3a9d21d
🔍 Latest deploy log	https://app.netlify.com/sites/hugo-portfolio-theme/deploys/65266071252fef0008a87cf2

[netlify]

✅ Deploy Preview for academic-demo canceled.

Name	Link
🔨 Latest commit	3a9d21d
🔍 Latest deploy log	https://app.netlify.com/sites/academic-demo/deploys/652660712a2c260009c52074

[etnguyen03]

If this gets merged/approved, I'd be interested in having something similar with the features block as well (and can open a PR if necessary)

[github-actions]

This PR is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help.

If you feel that the PR is still relevant in the latest release, consider making the PR easier to review and finding developers to help review the PR.

Please be mindful that although we encourage PRs, we cannot expand the scope of the project in every possible direction. There will be requests that don't make the roadmap.

This PR will automatically close soon if no further activity occurs. Thank you for your contributions.

[rodrigoalcarazdelaosa]

Since the triggering issue was closed, does it make sense to keep this PR?

[gcushen]

Since the triggering issue was closed, does it make sense to keep this PR?

Has this PR been tested? I recall a message in Discord (maybe a month ago) commenting that PNG logos were getting stretched or not appearing as expected - was that related to this PR?

[rodrigoalcarazdelaosa]

Can you test it with your use case, @rabinadk1? I think those issues with logos were related to the accomplishments block, @gcushen

[rabinadk1]

Can you test it with your use case, @rabinadk1? I think those issues with logos were related to the accomplishments block, @gcushen

Works for me. Thanks.

[github-actions]

This PR is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help.

If you feel that the PR is still relevant in the latest release, consider making the PR easier to review and finding developers to help review the PR.

Please be mindful that although we encourage PRs, we cannot expand the scope of the project in every possible direction. There will be requests that don't make the roadmap.

This PR will automatically close soon if no further activity occurs. Thank you for your contributions.

[rodrigoalcarazdelaosa]

Can you test it with your use case, @rabinadk1? I think those issues with logos were related to the accomplishments block, @gcushen

Works for me. Thanks.

@gcushen

[gcushen]

a few thoughts:

• you've removed the file extension from the error message, so it could be unclear to the user exactly what is missing
• we should not be adding new features to the deprecated v1 blocks, only to the current set of blocks
• if we add PNG support for the Experience block, users will likely expect PNG is supported in the Accomplishments block, so if we change one of these blocks, we should probably change both for consistency
• we should try to read the file as an SVG first as the icon library folder is intended to be an SVG icon library, and then perhaps fall back to searching for a PNG if it can't find SVG
• there are also now Git conflicts in the PR which would need addressing

[rodrigoalcarazdelaosa]

Closing the PR as this comment already offers a solution.