Adding Job Creation view, Job Details, refresh of the list, the choice of Collab #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ching by tags - to do...
…ching by tags - to do...
Conflicts fixed.
…oncat() is used when the list is reloaded (this avoids multiple entries for the same job.
…ation, since the joblist is sourced from 2 end-points (/results/ and /queue/)
… request headers in the hardware config field
Assorted improvements
apdavison
approved these changes
Mar 24, 2021
| @@ -3,17 +3,31 @@ | |||
| "version": "2.0.0dev", | |||
| "private": true, | |||
| "dependencies": { | |||
| "@fortawesome/fontawesome-svg-core": "^1.2.34", | |||
There was a problem hiding this comment.
I suggest we use icons only from Material UI, it will be confusing if we mix icons from two different sources
| @@ -3,11 +3,61 @@ import axios from 'axios'; | |||
| import { | |||
| useParams | |||
| } from "react-router-dom"; | |||
| //import { Button } from '@material-ui/core'; | |||
There was a problem hiding this comment.
todo: clean up commented-out code
| // import { Prism as SyntaxHighlighter } from 'react-syntax-highlighter'; | ||
| // import { dark } from 'react-syntax-highlighter/dist/esm/styles/prism'; | ||
| // <link rel="stylesheet" href="https://highlightjs.org/static/demo/styles/railscasts.css" /> | ||
| import ExpansionPanel from '@material-ui/core/ExpansionPanel'; |
There was a problem hiding this comment.
I think ExpansionPanel is now called Accordion
| @@ -16,39 +66,149 @@ function JobDetail(props) { | |||
| } | |||
| } | |||
| // const resultUrl = `https://raw.githubusercontent.com/jonathanduperrier/nmpi-job-manager-app-reactjs/master/db_${id}.json`; | |||
| const resultUrl = `https://nmpi.hbpneuromorphic.eu/api/v2/results/${id}/?collab_id=neuromorphic-testing-private`; | |||
| const resultUrl = `https://nmpi.hbpneuromorphic.eu/api/v2/results/${id}`; | |||
There was a problem hiding this comment.
todo: move API base URL (https://nmpi.hbpneuromorphic.eu/api/v2/) to a globals.js file
|
|
||
|
|
||
| let currentdate = new Date(); | ||
| let fetchDataDate = "Last updated: " + currentdate.getDate() + "/" |
There was a problem hiding this comment.
I think we do date formatting in a couple of places, so I suggest we make this a function and move it to a utils.js file
This was
linked to
issues
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the current status of our contributions. Thanks to @Haguili for the improved JobList. Since the last merge, jobs with 'submitted' and 'running' status have been added to the list. I added a small modification to avoid the 2-step refresh (because of 2 end-points), and to avoid multiple entries for the same job because of the concatenation of 2 lists.
Summary:
This pull request resolves issues #3, #4, #6, #7 and #9, i.e. the implementation of the Job Creation view, the Job Details, the refresh of the list, the choice of Collab, all using Material-UI.