Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency fixes #775

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Dependency fixes #775

merged 5 commits into from
Sep 7, 2023

Conversation

ernestum
Copy link
Collaborator

@ernestum ernestum commented Sep 5, 2023

Description

Fixes the broken huggingface_sb3 and seals versions.

Testing

Description of how you've tested your changes.

@ernestum ernestum requested review from Rocamonde and levmckinney and removed request for Rocamonde September 5, 2023 19:46
Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor suggestion

setup.py Outdated Show resolved Hide resolved
@AdamGleave AdamGleave merged commit 6e377b4 into master Sep 7, 2023
1 of 2 checks passed
@AdamGleave AdamGleave deleted the dependency_fixes branch September 7, 2023 22:57
lukasberglund pushed a commit to lukasberglund/imitation that referenced this pull request Sep 12, 2023
…AI#775)

* Pin huggingface_sb3 version.

* Properly specify the compatible seals version so it does not auto-upgrade to 0.2.

* Make random_mdp test deterministic by seeding the environment.

* Update setup.py

* Remove HuggingFace pin

---------

Co-authored-by: Adam Gleave <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants