Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in quickstart.py #823

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Fix warning in quickstart.py #823

merged 3 commits into from
Dec 12, 2023

Conversation

ernestum
Copy link
Collaborator

Fix warning in quickstart.py caused by not properly setting the render mode in the evaluation environment.

@ernestum ernestum mentioned this pull request Nov 30, 2023
@ernestum ernestum requested review from Rocamonde and taufeeque9 and removed request for dan-pandori and Rocamonde November 30, 2023 13:58
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (928d576) 95.66% compared to head (b854223) 95.66%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files         102      102           
  Lines        9655     9655           
=======================================
  Hits         9236     9236           
  Misses        419      419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernestum
Copy link
Collaborator Author

ernestum commented Dec 5, 2023

@AdamGleave can you merge this? The coverage changes seem spurious.

Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, will wait @taufeeque9's review & then merge once outstanding changes addressed

.circleci/config.yml Outdated Show resolved Hide resolved
@taufeeque9
Copy link
Collaborator

The changes look good to me. Should we also make the same changes in the tutorial notebooks by adding evaluation_env? I'm not sure if rendering will work with the jupyter notebooks.

@ernestum
Copy link
Collaborator Author

What do you mean @taufeeque9 ? We do not render anything in the tutorials as far as I know.

@taufeeque9
Copy link
Collaborator

What do you mean @taufeeque9 ? We do not render anything in the tutorials as far as I know.

Makes sense. I was also not sure so was just checking whether we need to make the same changes in docs/tutorials/1_train_bc.ipynb for example.

Copy link
Collaborator

@taufeeque9 taufeeque9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamGleave AdamGleave merged commit ab45b47 into master Dec 12, 2023
13 of 15 checks passed
@AdamGleave AdamGleave deleted the fix_warning_in_quickstart branch December 12, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants