-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning in quickstart.py #823
Conversation
…r mode in the evaluation environment.
468c15f
to
ad239f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 102 102
Lines 9655 9655
=======================================
Hits 9236 9236
Misses 419 419 ☔ View full report in Codecov by Sentry. |
@AdamGleave can you merge this? The coverage changes seem spurious. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, will wait @taufeeque9's review & then merge once outstanding changes addressed
The changes look good to me. Should we also make the same changes in the tutorial notebooks by adding |
Co-authored-by: Adam Gleave <[email protected]>
What do you mean @taufeeque9 ? We do not render anything in the tutorials as far as I know. |
Makes sense. I was also not sure so was just checking whether we need to make the same changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix warning in
quickstart.py
caused by not properly setting the render mode in the evaluation environment.