fix: LEAP-1490: Fix AudioUltra working with relations and comments #6494
+173
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
bmartel
reviewed
Oct 9, 2024
| @@ -131,6 +132,9 @@ export const AudioModel = types.compose( | |||
| }) | |||
| .volatile(() => ({ | |||
| errors: [], | |||
| stageRef: createRef(), | |||
| _ws: null, | |||
| _wf_frame: null, | |||
There was a problem hiding this comment.
Suggested change
| _wf_frame: null, | |
| _wfFrame: null, |
There was a problem hiding this comment.
I know there was historically a _ws_region which likely influenced this naming, but that was a mistake it should have been camelCase not snake_case. I don't know how ingrained _ws_region is already, but if at all possible could we rename both of these to camelCase like _wfFrame and _wsRegion.
bmartel
reviewed
Oct 9, 2024
| @@ -534,6 +538,9 @@ export const AudioModel = types.compose( | |||
| console.warn("Already destroyed"); | |||
| } | |||
| }, | |||
| setWFFrame(frame) { | |||
| self._wf_frame = frame; | |||
There was a problem hiding this comment.
Suggested change
| self._wf_frame = frame; | |
| self._wfFrame = frame; |
bmartel
reviewed
Oct 9, 2024
| })) | ||
| .views((self) => ({ | ||
| get bboxTriggers() { | ||
| return [self.start, self.end, self._ws_region, self.object?._ws, self.object?._wf_frame]; |
There was a problem hiding this comment.
Suggested change
| return [self.start, self.end, self._ws_region, self.object?._ws, self.object?._wf_frame]; | |
| return [self.start, self.end, self._wsRegion, self.object?._ws, self.object?._wfFrame]; |
bmartel
reviewed
Oct 9, 2024
| @@ -143,5 +166,14 @@ export const AudioUltraRegionModel = types | |||
| self.updatePosition(); | |||
| } | |||
| }, | |||
|
|
|||
| setWSRegion(wsRegion) { | |||
| self._ws_region = wsRegion; | |||
There was a problem hiding this comment.
Suggested change
| self._ws_region = wsRegion; | |
| self._wsRegion = wsRegion; |
bmartel
reviewed
Oct 9, 2024
Comment on lines
+31
to
+33
| const { _ws_region } = self; | ||
| if (!_ws_region) return null; | ||
| if (!_ws_region.inViewport) return null; |
There was a problem hiding this comment.
Suggested change
| const { _ws_region } = self; | |
| if (!_ws_region) return null; | |
| if (!_ws_region.inViewport) return null; | |
| const { _wsRregion } = self; | |
| if (!_wsRegion) return null; | |
| if (!_wsRegion.inViewport) return null; |
bmartel
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)