Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Add completed quests tab #1124

Merged
merged 16 commits into from
Nov 9, 2024
Merged

[UI/UX] Add completed quests tab #1124

merged 16 commits into from
Nov 9, 2024

Conversation

BrettCleary
Copy link
Collaborator

@BrettCleary BrettCleary commented Oct 23, 2024

Summary

closes https://github.com/HyperPlay-Gaming/product-management/issues/689

The deleted hooks were moved to the quests-ui recently so they are duplicated code in the client.

Testing

https://app.qase.io/case/HC-376
Note that on step 3, you will have to close the overlay/game and relaunch to see the quest move to the "Ready for claim" category. This is due to a regression that is fixed on #1111

@BrettCleary BrettCleary self-assigned this Oct 23, 2024
@BrettCleary BrettCleary marked this pull request as ready for review November 8, 2024 05:43
@BrettCleary BrettCleary added the PR: Ready-For-Review PR is ready to be reviewed by peers label Nov 8, 2024
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

src/frontend/hooks/useGetQuestStates.ts Outdated Show resolved Hide resolved
src/frontend/hooks/useGetQuestStates.ts Outdated Show resolved Hide resolved
src/frontend/hooks/useGetQuestStates.ts Outdated Show resolved Hide resolved
src/frontend/hooks/useGetQuestStates.ts Outdated Show resolved Hide resolved
@BrettCleary BrettCleary added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Nov 8, 2024
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Confirmed that after claiming the "points test 2" quest it does move to the Claimed tab.
  • Confirmed the quest does remain on the Claimed tab after a relaunch
  • Loving the new UI changes! Looks great!

image
image

@BrettCleary BrettCleary merged commit 9c5375e into main Nov 9, 2024
11 checks passed
@BrettCleary BrettCleary deleted the uiux/add_completed_tab branch November 9, 2024 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants