Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Download Action after canceling update from DM #1146

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented Nov 6, 2024

Fix an small issue on the download manager:

  • Start to update a game
  • Cancel the update
  • From the Finished Tab, click the Install Icon
  • It will open the installation modal instead of updating the game

Also:

  • Replace icon for cancelled update
  • Fixed titles (hover text) for all icons since they were wrong since we added actions.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima self-assigned this Nov 6, 2024
@flavioislima flavioislima added the PR: Ready-For-Review PR is ready to be reviewed by peers label Nov 6, 2024
Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flavioislima flavioislima added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Nov 6, 2024
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Confirmed that canceling a game update will display it in the Downloaded tab with the new Retry Update icon
  • Confirmed that other icons have updated mouseover text

image
image
image

@flavioislima flavioislima merged commit 8d860f4 into main Nov 8, 2024
11 checks passed
@flavioislima flavioislima deleted the fix/update_action_downm branch November 8, 2024 22:06
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants