[Feat] Add patching speed check #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettCleary
commented
Nov 9, 2024
Comment on lines
1693
to
1695
| // @TODO: get these speed values from local checks of download/write speed | ||
| const downloadSpeedInKBPerSecond = 25 * 1024 | ||
| const extractionSpeedInKBPerSecond = 50 * 1024 |
There was a problem hiding this comment.
open to suggestions here. I'd suggest we leave for another future iteration though
BrettCleary
commented
Nov 9, 2024
Comment on lines
1700
to
1701
| // @TODO: get this value from local check of patching speed | ||
| const patchingSpeedEstimateInKBPerSecond = 5 * 1024 |
There was a problem hiding this comment.
open to suggestions here as well. perhaps this could be the fallback value and we could attempt to get it from a LD flag?
There was a problem hiding this comment.
Maybe add an object with these amounts and we can import them from LD.
This way we can alter any of them to make the calculation more precise.
jiyuu-jin
approved these changes
Nov 12, 2024
eliobricenov
approved these changes
Nov 15, 2024
BrettCleary
added
PR: Ready-For-Test
nyghtstalker
approved these changes
Nov 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Throw if patching will take longer than the download.
Using rough estimate numbers to get some estimates.
Log with "Patching Too Slow" instead of "Patching Error" so metrics graphs don't see it as a failed event.
closes https://github.com/HyperPlay-Gaming/product-management/issues/755