[Metrics] Add wallet metrics #560

BrettCleary · 2023-09-28T07:39:38Z

Improve wallet metrics in onboarding modal
Update MetaMask Mobile to 0.12.0

I believe MMM metrics are automatically enabled on this version but am double checking with the team. This should not block this PR as it will at most be a one line change in the proxy server submodule

Fix MetaMask one time passcode (OTP) bug where it wouldn't show in some cases when reconnecting on subsequent app launches

Flowchart with events:
https://www.figma.com/file/JG7Rbq91JE8JbtvGVFNLPH/Metrics?type=whiteboard&node-id=0%3A1&t=RpQbfJfp1CIvv44j-1

Manual Test Cases are in qase under "Metrics -> Wallet Onboarding"

Submodule PR's

AC

Fire the MetaMask Extension event from the MetaMask SDK to help the MetaMask team with tracking
tracking events for all onboarding states

src/frontend/store/OnboardingStore.tsx

src/frontend/screens/Onboarding/index.tsx

src/frontend/screens/Onboarding/walletSelection/screens/import/index.tsx

eliobricenov

left some questions

src/frontend/screens/Onboarding/walletSelection/screens/import/index.tsx

BrettCleary · 2023-11-14T08:42:40Z

patches/@metamask+sdk+0.12.0.patch

this conflicts with our window.ethereum type definition in the frontend even though this is imported in the main process

There is also no reason for this to be exported by the node.js mm sdk. Created an issue here for it MetaMask/metamask-sdk#491

BrettCleary · 2023-11-14T08:48:51Z

Ready for review again @eliobricenov @flavioislima 👍

flavioislima · 2023-11-14T16:20:01Z

...rding/walletSelection/screens/import/components/BrowserPackageManagerImportOptions/index.tsx

+                <div
+                  className={styles.defaultProfileImage}
+                  style={{
+                    backgroundColor:


Can you maybe turn this into a variable to make to more readable and easy to change?
Also, the color code 202124 on a constant so would be easier to change in the future.

flavioislima · 2023-11-14T16:23:38Z

src/frontend/screens/Onboarding/walletSelection/screens/import/index.tsx

Nice refactor. Code is cleaner now using smaller components 👍🏽

flavioislima

Looks good overall.
left just some small comments 👍🏽

eliobricenov

lgtm!

...nboarding/walletSelection/screens/import/components/BrowsersAndManualImportOptions/index.tsx

red-game-dev · 2023-11-14T21:03:47Z

...nboarding/walletSelection/screens/import/components/BrowsersAndManualImportOptions/index.tsx

+        <div className={styles.profileOptionsContainer}>
+          {getPackageManagersForBrowser().map((pkgManager) => {
+            if (importOptions[browserSelected]![pkgManager].length === 0)
+              return null


For readability, lets at least put another new line under the return null or we wrap it with curly brackets

sure I'll add brackets but we should not enforce linting styles through code review. It wastes time. If it passes the linter, it should be okay

Here is the issue for adding eslint curly to enforce this at the linting level #581

...nboarding/walletSelection/screens/import/components/BrowsersAndManualImportOptions/index.tsx

...nboarding/walletSelection/screens/import/components/ImportAndCreateOptions/index.module.scss

red-game-dev

The above consider them as optional, so please do not feel blocked. LGTM 🙌

BrettCleary added the PR: WIP label Sep 28, 2023

BrettCleary self-assigned this Sep 28, 2023

BrettCleary added PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: WIP labels Sep 30, 2023

BrettCleary marked this pull request as ready for review September 30, 2023 06:59

eliobricenov self-requested a review October 2, 2023 19:06

eliobricenov reviewed Oct 3, 2023

View reviewed changes

src/frontend/store/OnboardingStore.tsx Outdated Show resolved Hide resolved

src/frontend/screens/Onboarding/index.tsx Outdated Show resolved Hide resolved

src/frontend/screens/Onboarding/walletSelection/screens/import/index.tsx Outdated Show resolved Hide resolved

eliobricenov reviewed Oct 3, 2023

View reviewed changes

flavioislima reviewed Oct 4, 2023

View reviewed changes

src/frontend/screens/Onboarding/walletSelection/screens/import/index.tsx Outdated Show resolved Hide resolved

flavioislima reviewed Oct 4, 2023

View reviewed changes

src/frontend/screens/Onboarding/walletSelection/screens/import/index.tsx Outdated Show resolved Hide resolved

flavioislima reviewed Oct 4, 2023

View reviewed changes

src/frontend/screens/Onboarding/walletSelection/screens/import/index.tsx Outdated Show resolved Hide resolved

BrettCleary removed PR: Ready-For-Review PR is ready to be reviewed by peers PR: Ready-For-Test PR is ready to be tested by a QA labels Oct 26, 2023

BrettCleary added 5 commits November 9, 2023 15:20

add wallet metrics, render debug logs

10b7548

fix metrics

efbbc4c

rm unused import

903def9

fix edge cases, improve connection reporting

bd7dbaa

rm log

7610e85

BrettCleary force-pushed the metrics/wallet_events branch from 1e7d4da to 7610e85 Compare November 9, 2023 23:31

BrettCleary added 9 commits November 9, 2023 15:48

revert electron extension installer

6646ea7

track wallet connected on backend, fix otp, rm walletstore

92f4341

ignore mm sdk-comm

2158643

revert wallet connected type

df3c2ef

rm otp updated handler

51ea735

rm random commented line

813a698

rm console log

11fba43

rm memo, fix connected screen event multiple sends

5544a2d

refactor walletSelection import screen

75116ce

BrettCleary commented Nov 10, 2023

View reviewed changes

src/frontend/screens/Onboarding/walletSelection/screens/import/index.tsx Show resolved Hide resolved

BrettCleary added 10 commits November 13, 2023 11:28

add back strict mode

8a7b80a

clean up ImportAndCreateOption

be33b58

onboarding metrics fixes

d75397e

patch metamask sdk

46f3acd

fix postinstall script call

5079d6b

Merge branch 'main' into metrics/wallet_events

f5b175f

prettier

af0af9a

fix test

e8f1a4d

fix import, mm sdk type

4559931

handle rejection

5131d9c

BrettCleary commented Nov 14, 2023

View reviewed changes

BrettCleary requested review from flavioislima and eliobricenov November 14, 2023 08:48

BrettCleary requested a review from nyghtstalker November 14, 2023 08:49

add strict mode back

c55bba3

flavioislima reviewed Nov 14, 2023

View reviewed changes

flavioislima approved these changes Nov 14, 2023

View reviewed changes

eliobricenov approved these changes Nov 14, 2023

View reviewed changes

red-game-dev reviewed Nov 14, 2023

View reviewed changes

...nboarding/walletSelection/screens/import/components/BrowsersAndManualImportOptions/index.tsx Outdated Show resolved Hide resolved

red-game-dev reviewed Nov 14, 2023

View reviewed changes

...nboarding/walletSelection/screens/import/components/BrowsersAndManualImportOptions/index.tsx Outdated Show resolved Hide resolved

red-game-dev reviewed Nov 14, 2023

View reviewed changes

...nboarding/walletSelection/screens/import/components/ImportAndCreateOptions/index.module.scss Show resolved Hide resolved

red-game-dev approved these changes Nov 14, 2023

View reviewed changes

BrettCleary added 3 commits November 14, 2023 22:49

refactor profile bg color into function

eb9cdfb

add translations and brackets

a29cc7b

merge submodules

e4d2fc3

BrettCleary merged commit 67fa89e into main Nov 15, 2023
13 of 14 checks passed

BrettCleary deleted the metrics/wallet_events branch November 15, 2023 07:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Metrics] Add wallet metrics #560

[Metrics] Add wallet metrics #560

BrettCleary commented Sep 28, 2023 •

edited

Loading

eliobricenov left a comment

BrettCleary Nov 14, 2023

BrettCleary commented Nov 14, 2023

flavioislima Nov 14, 2023

flavioislima Nov 14, 2023

flavioislima left a comment

eliobricenov left a comment

red-game-dev Nov 14, 2023

BrettCleary Nov 15, 2023

red-game-dev left a comment

[Metrics] Add wallet metrics #560

[Metrics] Add wallet metrics #560

Conversation

BrettCleary commented Sep 28, 2023 • edited Loading

eliobricenov left a comment

Choose a reason for hiding this comment

BrettCleary Nov 14, 2023

Choose a reason for hiding this comment

BrettCleary commented Nov 14, 2023

flavioislima Nov 14, 2023

Choose a reason for hiding this comment

flavioislima Nov 14, 2023

Choose a reason for hiding this comment

flavioislima left a comment

Choose a reason for hiding this comment

eliobricenov left a comment

Choose a reason for hiding this comment

red-game-dev Nov 14, 2023

Choose a reason for hiding this comment

BrettCleary Nov 15, 2023

Choose a reason for hiding this comment

red-game-dev left a comment

Choose a reason for hiding this comment

BrettCleary commented Sep 28, 2023 •

edited

Loading