Removing assertions from code and replacing with relevant exceptions

[asloobq]

Refactors

• move test method out of UIDOperatorService.java
• moving error message string literals to constants

TODO

• - run E2E tests
• integration deploy and test

[asloobq]

this condition is always true

[asloobq]

@mcollins-ttd FYI

[sunnywu]

this should be removed from the final merge?

[mcollins-ttd]

The line number in the stack trace won't tell us which of the items is null. Suggest instead

this.item1 = Objects.requireNonNull(item1);
this.item2 = Objects.requireNonNull(item2);
this.item3 = Objects.requireNonNull(item3);

Same for the other Tuple.

[mcollins-ttd]

Can readValue return null?

[asloobq]

Looks like it won't return a null value. If the input string is null it throws an IllegalArgumentException and Json*Exception for bad json string. I'll remove this check. Thanks

[mcollins-ttd]

Suggestion:

Suggested change

	try {
	V2RequestUtil.handleRefreshTokenInResponseBody(jsonBody, keyManager, IdentityScope.UID2);
	fail("IllegalArgumentException not thrown");
	} catch (IllegalArgumentException e) {
	assertEquals("Generated refresh token's length=168 is not equal to=388", e.getMessage());
	}
	IllegalArgumentException e = assertThrowsExactly(
	IllegalArgumentException.class,
	() -> V2RequestUtil.handleRefreshTokenInResponseBody(jsonBody, keyManager, IdentityScope.UID2));
	assertEquals("Generated refresh token's length=168 is not equal to=388", e.getMessage());

[sunnywu]

good that you renamed checkForInvalidTokenInput as after reading the original codes and what bool it returns, this method name is highly deceptive!