upgrade java 21 #611
Merged
upgrade java 21 #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
Ian-Nara
commented
Jul 9, 2024
| - name: Build UID2 AWS EIF | ||
| id: build_uid2_eif | ||
| uses: IABTechLab/uid2-operator/.github/actions/build_aws_eif@main | ||
| uses: IABTechLab/uid2-operator/.github/actions/build_aws_eif@ian-UID2-3362-upgrade-java-21 |
There was a problem hiding this comment.
change back to main before merging
cYKatherine
approved these changes
Jul 9, 2024
cYKatherine
reviewed
Jul 9, 2024
|
|
||
| - name: Check disk usage |
There was a problem hiding this comment.
Let's leave these for debugging purpose
thomasm-ttd
reviewed
Jul 10, 2024
| public void Shutdown(int status) { | ||
| System.exit(status); | ||
|
|
||
| // according to the docks, this should not be reached as System.exit does not complete either normally or abruptly. |
thomasm-ttd
reviewed
Jul 10, 2024
| System.setSecurityManager(origSecurityManager); | ||
| } | ||
| }); | ||
| testContext.completeNow(); |
There was a problem hiding this comment.
This test should assert that the shutdown service was not called
thomasm-ttd
reviewed
Jul 10, 2024
| System.setSecurityManager(origSecurityManager); | ||
| } | ||
| }); | ||
| verify(shutdownService).Shutdown(1); |
There was a problem hiding this comment.
This should be part of the assertAll
thomasm-ttd
reviewed
Jul 10, 2024
|
|
||
| when(clock.instant()).thenAnswer(i -> Instant.now().plus(12, ChronoUnit.HOURS)); | ||
| assertDoesNotThrow(() -> { | ||
| this.operatorShutdownHandler.handleSaltRetrievalResponse(false); |
There was a problem hiding this comment.
Assert shutdown service not called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.