-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade java 21 #611
upgrade java 21 #611
Conversation
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
…nto ian-UID2-3362-upgrade-java-21
- name: Build UID2 AWS EIF | ||
id: build_uid2_eif | ||
uses: IABTechLab/uid2-operator/.github/actions/build_aws_eif@main | ||
uses: IABTechLab/uid2-operator/.github/actions/build_aws_eif@ian-UID2-3362-upgrade-java-21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change back to main before merging
|
||
- name: Check disk usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave these for debugging purpose
public void Shutdown(int status) { | ||
System.exit(status); | ||
|
||
// according to the docks, this should not be reached as System.exit does not complete either normally or abruptly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs, not docks
System.setSecurityManager(origSecurityManager); | ||
} | ||
}); | ||
testContext.completeNow(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test should assert that the shutdown service was not called
System.setSecurityManager(origSecurityManager); | ||
} | ||
}); | ||
verify(shutdownService).Shutdown(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be part of the assertAll
|
||
when(clock.instant()).thenAnswer(i -> Instant.now().plus(12, ChronoUnit.HOURS)); | ||
assertDoesNotThrow(() -> { | ||
this.operatorShutdownHandler.handleSaltRetrievalResponse(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assert shutdown service not called
No description provided.