Respond with 400 instead of 500 when CSTG request validation fails #633
Conversation
| @@ -453,6 +453,10 @@ else if(emailHash != null) { | |||
| input = InputUtil.normalizePhoneHash(phoneHash); | |||
| } | |||
|
|
|||
| if (this.phoneSupport ? !checkTokenInputV1(input, rc) : !checkTokenInput(input, rc)) { | |||
There was a problem hiding this comment.
This expression this.phoneSupport ? !checkTokenInputV1(input, rc) : !checkTokenInput(input, rc) appears 6 times in this file and ideally should be wrapped in a method
There was a problem hiding this comment.
The only difference between checkTokenInputV1 and checkTokenInput is the error message returned.
Can we remove checkTokenInputV1 and do the this.phoneSupport check in checkTokenInput?
There was a problem hiding this comment.
I removed the checkTokenInputV1 and did the this.phoneSupport check in checkTokenInput. Also invert the method.
| } | ||
|
|
||
| @Test | ||
| void cstgInvalidPhoneHashInput(Vertx vertx, VertxTestContext testContext) throws NoSuchAlgorithmException, InvalidKeyException { |
There was a problem hiding this comment.
possible to eliminate some of the duplication? the tests are identical other than the input. Can the input be parameterized?
There was a problem hiding this comment.
That is a good idea, I used the @ParameterizedTest
| @@ -453,6 +453,10 @@ else if(emailHash != null) { | |||
| input = InputUtil.normalizePhoneHash(phoneHash); | |||
| } | |||
|
|
|||
| if (checkTokenInput(input, rc)) { | |||
There was a problem hiding this comment.
if (checkTokenInput) makes it seem like it succeeded. How about we rename this method to checkForInvalidTokenInput?
There was a problem hiding this comment.
I rename checkTokenInput to checkForInvalidTokenInput. true for invalid input, false for valid input.
No description provided.