-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for incorrect dimension-accessors when initializing from pandas #763
Conversation
Codecov Report
@@ Coverage Diff @@
## main #763 +/- ##
=====================================
Coverage 94.4% 94.4%
=====================================
Files 59 59
Lines 6080 6086 +6
=====================================
+ Hits 5744 5750 +6
Misses 336 336
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one suggestion for a more defensive way to write the test (not an essential change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful thanks a lot @danielhuppmann 🎉
ok, thanks, indeed, that is the issue i encountered today. i would have suggested to replace calls to
so they can decide what is the most efficient solution, but your fix is also fine. |
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
This PR introduces an explicit removal of unused levels when initializing from a pandas object. This bug could lead to inconsistent return-values of the dimension-accessors.
closes #762