Packaging modules as single package with extra (data-prep-kit[ray,spark] and data-prep-kit-tranforms[all, ray, etc.]) #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
… need to install the rquirements.txt seperately Signed-off-by: Maroun Touma <[email protected]>
…nsforms folder Signed-off-by: Maroun Touma <[email protected]>
touma-I
changed the title
touma-I
changed the title
daw3rd
reviewed
Oct 7, 2024
| @@ -627,7 +636,7 @@ MINIO_ADMIN_PWD= localminiosecretkey | |||
| rm -rf dist || true | |||
| rm -rf src/*egg-info || true | |||
| ${PIP} install --upgrade build | |||
| ${PYTHON} -m build | |||
| ${PYTHON} -m build $(BUILD_WHEEL_ARG) | |||
There was a problem hiding this comment.
Can we renaming BUILD_WHEEL_ARG to PYTHON_BUILD_EXTRA_ARGS to match DOCKER_BUILD_EXTRA_ARGS?
There was a problem hiding this comment.
and a default (empty?) should be defined above, similar to DOCKER_BUILD_EXTRA_ARGS
There was a problem hiding this comment.
Hi @daw3rd . No need for Default. The default is none anyway.
Signed-off-by: Maroun Touma <[email protected]>
Consistency of installing new pip installs
New pip install option for Ray
Use "all" option for the new pip install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In this release, we create a single pypi package for data-prep-kit[dev,ray,spark] and a single data-prep-kit-transforms[all,ray,code_quality,doc_id,etc]
Related issue number (if any).
#673