Update test-kfp.yml workflow. #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daw3rd
approved these changes
Oct 14, 2024
.github/workflows/test-kfp.yml
Outdated
| chmod +x /tmp/mc | ||
| export DEPLOY_KUBEFLOW=1 | ||
| make -C $K8S_SETUP_SCRIPTS setup | ||
| KFP_BLACK_LIST=$(./scripts/check-workflows.sh -show-kfp-black-list) |
There was a problem hiding this comment.
Can you move the black list down to just before the while loop? THis way I know that it is not being used by the next few lines (assuming that is the case). Needs to be done in two places.
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
Signed-off-by: Revital Sur <[email protected]>
daw3rd
requested changes
Oct 14, 2024
.github/workflows/test-kfp.yml
Outdated
| @@ -9,7 +9,6 @@ on: | |||
| tags: | |||
| - "*" | |||
| paths: | |||
| - ".make.*" | |||
There was a problem hiding this comment.
kfp/Makefile includes .make.defaults, so this should be included.
daw3rd
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR updates test-kfp.yaml workflow as was done for test-kfp-transform.template