Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add namespace selector for skipping admission #449

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

jhanbo
Copy link
Contributor

@jhanbo jhanbo commented Oct 30, 2023

Hi there,

part of the admission control best practises is to skip kube-system namespace. This PR would add an option for a user to create a matchExpression which suits their case.

Hope that suits well,
Johnny

Copy link
Member

@sjhx sjhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that this is very much opt in by updating values this, dafult toaccepting this contribution

@sjhx sjhx added this pull request to the merge queue Oct 31, 2023
Merged via the queue into IBM:main with commit 9b3e619 Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants