Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the OpenAPI feature #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adding the OpenAPI feature #4

wants to merge 5 commits into from

Conversation

JunyiSun
Copy link

@JunyiSun JunyiSun commented Jul 12, 2018 •
edited
Loading

  • Added OpenAPI annotations to each resource
  • OpenAPI requires POJOs, not JsonObject, so we converted portfolio JsonBuilder to portfolio model class initialization; same for the stock model.

@yeekangc
Copy link
Member

@jwalcorn, can you please take a look at this PR and let us know your feedback? Thank you.

@yeekangc
Copy link
Member

@JunyiSun, I think we should fix up the code formatting to be consistent with how it has been done.

@JunyiSun
Copy link
Author

@yeekangc I re-formatted the file so it's clearer what has been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JunyiSun @yeekangc