Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: android assets #2073

Merged
merged 4 commits into from
Aug 31, 2023
Merged

hotfix: android assets #2073

merged 4 commits into from
Aug 31, 2023

Conversation

jfmcquade
Copy link
Collaborator

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

The build_android action was failing with the error:

> Task :capacitor-community-firebase-crashlytics:processReleaseManifest
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:mergeReleaseResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
> Task :app:mergeReleaseResources FAILED
> Task :capacitor-cordova-android-plugins:extractDeepLinksRelease

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/8.0.2/userguide/command_line_interface.html#sec:command_line_warnings
48 actionable tasks: 48 executed
   > Android resource compilation failed
     ERROR: /home/runner/work/parenting-app-ui/parenting-app-ui/android/app/src/main/res/mipmap-mdpi/ic_launcher_background.png: AAPT: error: file failed to compile.

This PR updates the Android assets (by running yarn workflow populate_android_assets), as well as manually updating the android/app/src/main/res/mipmap-mdpi/ic_launcher_background.png that seemed to be causing an issue (the file is just a white square).

Whilst this may not be the cause of the issue, at some point we should move from using the now deprecated cordova-res library to the @capacitor/assets library. Issue here: #2072

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes

@jfmcquade jfmcquade merged commit fef2844 into deployment/plh_tz Aug 31, 2023
4 checks passed
@jfmcquade jfmcquade deleted the fix/android-assets branch August 31, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant