Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix test-appetize action trigger #2502

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jfmcquade
Copy link
Collaborator

PR Checklist

  • PR title descriptive (can be used in release notes)

Description

Follow-up to #2200, this PR reinstates the PR label trigger such that the test-appetize action will be run if the test - appetize label is added to a PR.

As noted in #2200, an APPETIZE_APP_KEY secret must be added to the targeted content repo. This is the "Build Identifier", i.e. the last section of the URL path, https://appetize.io/app/{buildId}, see official appetize docs. This can only be obtained after an initial build has been uploaded manually to appetize. I have update the debug content repo accordingly.

Git Issues

Closes #

Screenshots/Videos

@jfmcquade jfmcquade added the test - appetize Build and deploy android apk to appetize.io label Nov 4, 2024
@@ -31,7 +33,9 @@ jobs:
uses: ./.github/workflows/reusable-android-build.yml
secrets: inherit
with:
branch: ${{ github.base_ref }}
branch: ${{ github.ref }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reusable branch input refers to the branch of the deployment repo to checkout, not the ref of the builder repo which is set via env.APP_CODE_BRANCH

So I don't think it's possible to get the reusable action working in this way when being called from the builder repo itself. Instead we would need to add a different action for the builder repo like we do for pr-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test - appetize Build and deploy android apk to appetize.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants