Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified seo tags #110

Merged
merged 34 commits into from
Feb 25, 2024
Merged

modified seo tags #110

merged 34 commits into from
Feb 25, 2024

Conversation

imApoorva36
Copy link
Contributor

@imApoorva36 imApoorva36 commented Jan 23, 2024

Description

Added the seo tags for the website

Fixes # (91)

Dependencies

List any dependencies that are required for this change.

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Test A
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@imApoorva36 imApoorva36 changed the title modified seo tags on base.html modified seo tags Jan 24, 2024
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Additionally, I would recommend you look at what each meta tag is really doing and what it represents. It is good information to know for SEO.
Maybe you can even add additional tags for updated SEO.

corpus/templates/base.html Outdated Show resolved Hide resolved
corpus/templates/base.html Outdated Show resolved Hide resolved
corpus/templates/base.html Show resolved Hide resolved
corpus/templates/base.html Outdated Show resolved Hide resolved
@imApoorva36
Copy link
Contributor Author

I have reverted with optimized content and I've also added all the images as required and added a favicon too

Do let me know in case of any more changes if required :)

@imApoorva36
Copy link
Contributor Author

I have reverted with optimized content and I've also added all the images as required and added a favicon too

Do let me know in case of any more changes if required :)

Also I just realised that I also added the favicon, linked from issue #76 too, as it was as well along with the icons in the old website icons' collection. Just informing.

@nishant-nayak
Copy link
Member

If you can, can you also replace the text Corpus on the navbar with the IEEE NITK logo? The requirement is listed in #76 , if you can add that then we can close both issues in this PR

This was linked to issues Jan 29, 2024
Copy link

livecycle bot commented Feb 18, 2024

ieee-nitk

Your Livecycle playground is ready 🎉.

Playground version up to date (84733e0)

Invite team members and start collaborating 💪

Check the box and click "invite" to invite collaborators

  • Nishant Nayak
  • Anirudh Prabhakaran

invite

Click here to invite the rest of your team.

@imApoorva36 imApoorva36 deleted the seo-tags branch February 18, 2024 18:36
@imApoorva36 imApoorva36 restored the seo-tags branch February 18, 2024 18:36
@imApoorva36 imApoorva36 reopened this Feb 18, 2024
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some small UI changes.

corpus/templates/components/navbar_large.html Outdated Show resolved Hide resolved
corpus/templates/components/navbar_small.html Outdated Show resolved Hide resolved
@nishant-nayak
Copy link
Member

image
The logo in the navbar does not render properly on the SIG pages. Look into why this issue is occurring.

@imApoorva36
Copy link
Contributor Author

image The logo in the navbar does not render properly on the SIG pages. Look into why this issue is occurring.

ah yes, sorry, it was due to relative path in the navbar logo and not absolute path , fixed for both navbar_large and navbar_small

corpus/templates/components/navbar_large.html Outdated Show resolved Hide resolved
corpus/templates/components/navbar_small.html Outdated Show resolved Hide resolved
Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on both issues #76 and #91

@nishant-nayak nishant-nayak merged commit 7e7fd34 into IEEE-NITK:main Feb 25, 2024
1 check passed
@imApoorva36 imApoorva36 deleted the seo-tags branch February 25, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SEO Tags Add branding to the website
3 participants